Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform struct fields of array enum type to query/formData params #1523

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Mar 31, 2023

Describe the PR
Transform struct fields of array enum type to query/formData params

Relation issue
#1521

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.13 ⚠️

Comparison is base (314d61f) 83.87% compared to head (f1d9311) 83.74%.

❗ Current head f1d9311 differs from pull request most recent head 6cfef59. Consider uploading reports for the commit 6cfef59 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   83.87%   83.74%   -0.13%     
==========================================
  Files          19       19              
  Lines        3726     3735       +9     
==========================================
+ Hits         3125     3128       +3     
- Misses        517      520       +3     
- Partials       84       87       +3     
Impacted Files Coverage Δ
operation.go 95.03% <50.00%> (-0.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdghchj sdghchj requested a review from ubogdan April 3, 2023 01:41
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sdghchj sdghchj merged commit e67c965 into master Apr 4, 2023
@sdghchj sdghchj deleted the array_enum_fields_on_query branch April 4, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants