Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid response type: array of strings #173

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Jul 24, 2018

Describe the PR
fix invalid response type: array of strings

Relation issue
close #172

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #173 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   89.24%   89.39%   +0.14%     
==========================================
  Files           5        5              
  Lines         939      952      +13     
==========================================
+ Hits          838      851      +13     
  Misses         60       60              
  Partials       41       41
Impacted Files Coverage Δ
schema.go 100% <100%> (ø) ⬆️
operation.go 92.81% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b32e23...d20046b. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 741541c into master Jul 25, 2018
@pei0804 pei0804 deleted the pei-fix-172 branch July 29, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid response type: array of strings
3 participants