Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom primitive types #198

Merged
merged 4 commits into from
Sep 1, 2018
Merged

Conversation

abdulito
Copy link
Contributor

Handle custom primitive types

#164

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #198 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   88.59%   88.76%   +0.17%     
==========================================
  Files           5        5              
  Lines        1008     1024      +16     
==========================================
+ Hits          893      909      +16     
  Misses         72       72              
  Partials       43       43
Impacted Files Coverage Δ
property.go 92.64% <100%> (+0.58%) ⬆️
parser.go 87.8% <100%> (+0.12%) ⬆️
schema.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62a15d...444da10. Read the comment docs.

Copy link
Member

@pei0804 pei0804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good! thx!
LGTM

@pei0804 pei0804 merged commit d18ec72 into swaggo:master Sep 1, 2018
@easonlin404
Copy link
Member

@pei0804 @abdulito I think we should add example/tutorial for this feature, rest LGTM. 😄

@abdulito abdulito mentioned this pull request Sep 10, 2018
@duguying
Copy link

how to use

@duguying
Copy link

it seems not support type Time time.Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants