Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for composition objects with pointers. #226

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

rubensayshi
Copy link
Contributor

@rubensayshi rubensayshi commented Oct 23, 2018

Describe the PR
this pull request adds support for embedded structs / composition with pointers.

type Foo struct {
	Field1 string
}
type Bar struct {
	Field2 string
}

// this was working
type FooBarWorking struct {
	Foo
	Bar
}

// this was not working
type FooBarNotWorking struct {
	*Foo
	*Bar
}

@rubensayshi
Copy link
Contributor Author

I don't understand why the go1.8 build is failing on travis ... it seems to fail on make deps o.O?

@asdptkt
Copy link

asdptkt commented Oct 24, 2018

Welp, and I need this too.

@rubensayshi
Copy link
Contributor Author

rubensayshi commented Oct 24, 2018

tests fail because go 1.8, see; #228

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@rubensayshi Thanks for your contributions. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants