Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mapType #283

Merged
merged 3 commits into from
Jan 16, 2019
Merged

support mapType #283

merged 3 commits into from
Jan 16, 2019

Conversation

congcongke
Copy link
Contributor

Describe the PR
support mapType for data definition.

Relation issue

Additional context
when I generate the doc file with swag tool, the map type is generated as a object simply. I know this situation can be handled by swagger. I think this may be useful and the change seems pretty small. Hope to contribute this project.
Big thanks!

@easonlin404
Copy link
Member

@congcongke can you help add tests?

@congcongke
Copy link
Contributor Author

@congcongke can you help add tests?
@easonlin404 done

@congcongke
Copy link
Contributor Author

@easonlin404 To merge it to the master, anything help from me?

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 2a57949 into swaggo:master Jan 16, 2019
@easonlin404
Copy link
Member

Thanks for your contributions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants