Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add output flag to specify output dir #325

Merged
merged 3 commits into from
Mar 20, 2019
Merged

feat: add output flag to specify output dir #325

merged 3 commits into from
Mar 20, 2019
+111 −33

Conversation

easonlin404
Copy link
Member

@easonlin404 easonlin404 commented Mar 19, 2019 •
edited
Loading

address #257 #251

@codecov-io
Copy link

codecov-io commented Mar 19, 2019 •
edited
Loading

Codecov Report

Merging #325 into master will increase coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #325      +/-   ##
========================================
+ Coverage   86.99%    87%   +0.01%     
========================================
  Files           7      7              
  Lines        1276   1277       +1     
========================================
+ Hits         1110   1111       +1     
  Misses        103    103              
  Partials       63     63
Impacted Files Coverage Δ
gen/gen.go 68.18% <90.9%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fc758...f21e94e. Read the comment docs.

@easonlin404 easonlin404 changed the title [WIP] feat: add cli flag for output doc.go [WIP] feat: add output flag to specify output dir Mar 19, 2019
@easonlin404 easonlin404 requested review from pei0804 and removed request for pei0804 March 19, 2019 10:50
@easonlin404 easonlin404 changed the title [WIP] feat: add output flag to specify output dir feat: add output flag to specify output dir Mar 20, 2019
@easonlin404
Copy link
Member Author

easonlin404 commented Mar 20, 2019 •
edited
Loading

This PR will also remove--swagger flag, using --output flag to unify output files output dir.

@pei0804

@pei0804
Copy link
Member

pei0804 commented Mar 20, 2019

👀

pei0804
pei0804 reviewed Mar 20, 2019
View reviewed changes
gen/gen.go
@@ -23,17 +23,32 @@ func New() *Gen {
return &Gen{}
}

// Config presents Gen configurations.
type Config struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pei0804
Copy link
Member

pei0804 commented Mar 20, 2019 •
edited
Loading

This section change often so I delete it.
eg: This PR make gap.
https:/swaggo/swag#swag-cli

pei0804
pei0804 reviewed Mar 20, 2019
View reviewed changes
gen/gen_test.go
t.Fatal(err)
}

//TODO: remove gen files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outputdir has been replace so it's ok now.

pei0804
pei0804 approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@pei0804 pei0804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pei0804 pei0804 merged commit 9161028 into master Mar 20, 2019
@pei0804 pei0804 deleted the add-cli-flag-for-output-docs branch March 20, 2019 12:16
This was referenced Mar 20, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pei0804 pei0804 pei0804 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easonlin404 @codecov-io @pei0804