add support for 1.12.x and update make install #342
Merged
+72
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 7 7
Lines 1264 1264
=======================================
Hits 1109 1109
Misses 92 92
Partials 63 63Continue to review full report at Codecov.
|
|
@easonlin404 plz review. |
pei0804
changed the title
|
sry wait. |
pei0804
changed the title
|
@easonlin404 review plz. |
easonlin404
reviewed
Mar 23, 2019
easonlin404
reviewed
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
#326 (review)
go 1.10.x below user use
go get.go 1.11.x top user use
go module.And each version can use Makefile.