Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor parseAndExtractionParamAttribute #354

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Mar 24, 2019

Describe the PR
refactor parseAndExtractionParamAttribute.

@pei0804 pei0804 changed the title refactor parseAndExtractionParamAttribute [WIP]refactor parseAndExtractionParamAttribute Mar 24, 2019
@codecov-io
Copy link

codecov-io commented Mar 24, 2019

Codecov Report

Merging #354 into master will decrease coverage by 0.01%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   85.59%   85.58%   -0.02%     
==========================================
  Files           7        7              
  Lines        1305     1304       -1     
==========================================
- Hits         1117     1116       -1     
  Misses        109      109              
  Partials       79       79
Impacted Files Coverage Δ
operation.go 86.66% <74.19%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3320652...852cb6c. Read the comment docs.

@pei0804
Copy link
Member Author

pei0804 commented Mar 24, 2019

@easonlin404

@pei0804 pei0804 changed the title [WIP]refactor parseAndExtractionParamAttribute refactor parseAndExtractionParamAttribute Mar 24, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pei0804 pei0804 merged commit 3a5aa94 into master Mar 24, 2019
@pei0804 pei0804 deleted the fix-gocyclo-over15-4 branch March 24, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants