Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dbus-java 4.x #31

Closed
overheadhunter opened this issue Jan 27, 2022 · 10 comments
Closed

Update to dbus-java 4.x #31

overheadhunter opened this issue Jan 27, 2022 · 10 comments

Comments

@overheadhunter
Copy link
Collaborator

This is a feature request that will not be downwards compatible and may require a new major version:

Could you please update dbus-java to version 4? It got modularized and offers a variety of transport implementations, including dbus-java-transport-native-unixsocket, which relies on Java's native unix sockets, so we could get rid of the dependency to the whole JNR ecosystem.

This requires to bump the JDK to 17 (technically 16, but I guess LTS makes more sense). On the long run, this is the most important step to make this library work with Java's module system.

@swiesend
Copy link
Owner

swiesend commented Feb 7, 2022

I have seen it. Last time I checked there was no jar on maven yet, as the 4.x version was just released. I try it for this week. Will also update the intergrations-linux.

@swiesend
Copy link
Owner

swiesend commented Apr 3, 2022

I found some time to integrate dbus-java 4.x.x. I am planning to release it together with my 2.x.x API, that will provide a FP friendly API, as you suggested in: #7

I want to release my 2.0.0, when dbus-java 4.1.x will be available.

https:/swiesend/secret-service/tree/develop-2.x.x

@overheadhunter
Copy link
Collaborator Author

overheadhunter commented Apr 4, 2022

This may be a little off topic but since you mentioned working on a new major version (and probably don't want to have further breaking changes after releasing it): Please consider using a package namespace that you have sole control over, as org.gnome.* and org.freedesktop.* etc will lead to split packages in the post-Java-8 modular world.

Convention would be for Maven group/artifact, Java module name and root package name to match.

@brett-smith
Copy link

I've also been waiting on dbus-java 4.1.x for other purposes, as well as being a consumer of this library (via https:/javakeyring/java-keyring). So just thought I'd point out 4.1.0 has now been released :)

@swiesend
Copy link
Owner

So just thought I'd point out 4.1.0 has now been released :)

Thanks @brett-smith! Currently I am on vaccation without my laptop. I am happy to use it when I am back in about two weeks.

@overheadhunter
Copy link
Collaborator Author

Since the jnr-based unix sockets implementation might fail in downstream projects, may I ask for our users, if there is any progress with this?

@swiesend
Copy link
Owner

swiesend commented Oct 7, 2022

@overheadhunter there is some progress, but its not pushed as it is not finished. Recently my father died and there are too many things going on right now. I try to find some spare time to get if off the table, but that probably need some more weeks. But its not forgotten.

@overheadhunter
Copy link
Collaborator Author

So sorry to hear that! Trust me, I know how this can derail one's life from one day to the other.

Don't feel pushed, I was just curious what is the status of this issue.

@infeo
Copy link
Contributor

infeo commented Jan 16, 2023

This issue is completed with the release of https:/swiesend/secret-service/tree/v1.8.0-jdk17.

@swiesend
Copy link
Owner

There is https:/swiesend/secret-service/releases/tag/v1.8.1-jdk17 with dbus-java-transport-native-unixsocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants