Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better type annotations for rst.get_feature #409

Closed
alcarney opened this issue Jun 14, 2022 · 0 comments · Fixed by #419
Closed

Better type annotations for rst.get_feature #409

alcarney opened this issue Jun 14, 2022 · 0 comments · Fixed by #419
Labels
api Issues that relate to APIs lsp Issues that relate to the language server

Comments

@alcarney
Copy link
Member

I'm fairly sure we can do some type annotation magic so that the return type of rst.get_feature matches the requested feature, removing the need for # type comments or similar
@alcarney alcarney added lsp Issues that relate to the language server api Issues that relate to APIs labels Jun 14, 2022
@alcarney alcarney mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Issues that relate to APIs lsp Issues that relate to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better type annotations and dependency injection alcarney/esbonio
1 participant
@alcarney