Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to workspace configuration #527

Closed
alcarney opened this issue Jan 14, 2023 · 0 comments · Fixed by #679
Closed

Switch to workspace configuration #527

alcarney opened this issue Jan 14, 2023 · 0 comments · Fixed by #679
Labels
enhancement New feature or request lsp Issues that relate to the language server
Milestone
1.0

Comments

@alcarney
Copy link
Member

Currently the language server relies on the client sending initializationOptions to get its settings, aside from not having any support for multiple scopes, any change requires a full restart of the server.

A much better approach would be to use workspace/configuration requests and listen for the relevant did change notifications.
@alcarney alcarney added enhancement New feature or request lsp Issues that relate to the language server labels Jan 14, 2023
@alcarney alcarney added this to the Multi root awareness milestone Jan 14, 2023
@alcarney alcarney mentioned this issue Jun 16, 2023
Merged
@alcarney alcarney modified the milestones: Multi root awareness, 1.0 Oct 11, 2023
@alcarney alcarney mentioned this issue Nov 10, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lsp Issues that relate to the language server
Projects
Esbonio
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Overhaul server configuration alcarney/esbonio
1 participant
@alcarney