-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server does not detect invalid references #57
Labels
Comments
alcarney
added
bug
Something isn't working
lsp
Issues that relate to the language server
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Jan 22, 2021
alcarney
added a commit
that referenced
this issue
Feb 24, 2021
By running the full build, we are now able to catch errors like invalid references and benefit from Sphinx's caching logic. Also by updating the `PROBLEM_PATTERN` regex, we can catch errors that do not have an associated line number. `DiagnosticList` is a way to ensure we don't get repeat reports of the same issue, but might become a performance issue depending on project scale. Closes #94 Closes #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
For example the reference
:ref:`not-a-valid-reference`
is not flagged as an issueNot sure if this should be solved by running more of the Sphinx build process (current we only read the sources) or if there should be a dedicated feature that checks for this kind of thing
The text was updated successfully, but these errors were encountered: