Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError when typing directive options in MyST #800

Closed
alcarney opened this issue Apr 29, 2024 · 0 comments · Fixed by #829
Closed

ValueError when typing directive options in MyST #800

alcarney opened this issue Apr 29, 2024 · 0 comments · Fixed by #829
Labels
bug Something isn't working lsp Issues that relate to the language server
Milestone

Comments

@alcarney
Copy link
Member

Expected behavior

When typing something like

```{eval-rst}

.. autoclass:: my.module.Class
   :members:

```

There are a bunch of ValueErrors in the logs from the _render_myst_role_with_text_edit function due to it trying to create a Position instance with a negative line or character value.

Thankfully error handling elsewhere in the server prevents this from being a major issue

Actual behavior

ValueErrors should not be raised

Log output

No response

(Optional) Settings from conf.py

No response

@alcarney alcarney added bug Something isn't working lsp Issues that relate to the language server labels Apr 29, 2024
@alcarney alcarney added this to the 1.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp Issues that relate to the language server
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant