-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul server configuration #679
Commits on Nov 9, 2023
-
lsp: Add dedicated configuration component
The idea is that all configuration will be managed in a centralised location. The `WorkspaceConfiguration` component will be attached to the main language server will be responsible from merging configuration values from a number of sources. - Initialization options - ``workspace/configuration`` requests - Configuration files While this is not implemented yet, this component will also make sure that the configuration values are kept up to date. Eventually features will be able to subscribe to changes in the sections that they are interested in.
Configuration menu - View commit details
-
Copy full SHA for a6b47e0 - Browse repository at this point
Copy the full SHA a6b47e0View commit details
Commits on Nov 10, 2023
-
lsp: Reimplement workspace/configuration requests
Upon receiving the `initialized` notification the server dynamically registers to receive `workspace/didChangeConfiguration` notifications, if the client supports it. The server will also early request the entire `esbonio` configuration section for each workspace root and the global config so that it's ready to serve internal configuration requests from features. This commit also updates the old uses of `server.get_user_config` to use the new `server.configuration.get` API
Configuration menu - View commit details
-
Copy full SHA for b12137b - Browse repository at this point
Copy the full SHA b12137bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05255fc - Browse repository at this point
Copy the full SHA 05255fcView commit details -
lsp: Move logging code to a LanguageFeature
Rather than have the logging setup be anything "special", it is now just another LanguageFeature allowing it to take advantage of the APIs provided to them.
Configuration menu - View commit details
-
Copy full SHA for 2261e71 - Browse repository at this point
Copy the full SHA 2261e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc9377 - Browse repository at this point
Copy the full SHA 0fc9377View commit details -
code: Update
pythonCommand
injection codeTo align with the changes in how the server asks for configuration values, this updates and simplifies the code that injects the user's configured Python environment into returned configuration.
Configuration menu - View commit details
-
Copy full SHA for 3e3d749 - Browse repository at this point
Copy the full SHA 3e3d749View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95b8fd9 - Browse repository at this point
Copy the full SHA 95b8fd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 260400c - Browse repository at this point
Copy the full SHA 260400cView commit details
Commits on Nov 17, 2023
-
code: Refactor lsp-devtools support
`lsp-devtools` is too heavy a dependency to bundle for it to be worth it, especially when you consider the proportion of users who are actually going to make use of it. Instead, the extension now assumes that it is available on the user's PATH
Configuration menu - View commit details
-
Copy full SHA for b0f036e - Browse repository at this point
Copy the full SHA b0f036eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 949a7f1 - Browse repository at this point
Copy the full SHA 949a7f1View commit details -
code: Only send options the user has configured
Since the language server treats `workspace/configuration` requests as an override for any options set via config file, it's now important to only send the options that the user has actually set. This means most config options in the VSCode extension are now `null` by default.
Configuration menu - View commit details
-
Copy full SHA for 9822a36 - Browse repository at this point
Copy the full SHA 9822a36View commit details -
lsp: Use
pyproject.toml
files as a config sourceOptions are read from the `tool.esbonio` namespace
Configuration menu - View commit details
-
Copy full SHA for 80e21b4 - Browse repository at this point
Copy the full SHA 80e21b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee3d1d3 - Browse repository at this point
Copy the full SHA ee3d1d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be0d1b - Browse repository at this point
Copy the full SHA 3be0d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31fb89a - Browse repository at this point
Copy the full SHA 31fb89aView commit details
Commits on Nov 18, 2023
-
lsp: Register
workspace/didChangeWatchedFiles
handlerFor clients that support it, the language server will be able to listen for changes to `pyproject.toml` files and update its configuration accordingly.
Configuration menu - View commit details
-
Copy full SHA for 13139d9 - Browse repository at this point
Copy the full SHA 13139d9View commit details -
docs: Update configuration docs
- Move to reference section - Add a custom domain to document esbonio - Explain the updated configuration behavior
Configuration menu - View commit details
-
Copy full SHA for f336f36 - Browse repository at this point
Copy the full SHA f336f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6643e9 - Browse repository at this point
Copy the full SHA f6643e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddf0e1a - Browse repository at this point
Copy the full SHA ddf0e1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b71bae2 - Browse repository at this point
Copy the full SHA b71bae2View commit details