Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stalebot should not close feature requests #15790

Open
pataquets opened this issue Oct 28, 2022 · 10 comments
Open

Stalebot should not close feature requests #15790

pataquets opened this issue Oct 28, 2022 · 10 comments

Comments

@pataquets
Copy link
Contributor

pataquets commented Oct 28, 2022

I know it can be helpful to tame the amount of issues.
But closing FRs is counterproductive. It can lead to filing duplicate FRs, and losing previous discussions.
I'd suggest to make stalebot leave alone issues labelled as FRs and optionally add "help wanted" labels for FRs not having maintainers on it, which is understandable. Also, such a label sends a clear message about expectations.

As an example, here's an issue worthwhile IMO which I was about to file again: #9451.
EDIT: Almost happened again: #9925.

@smile13241324
Copy link
Collaborator

Good point, I think this bot is controlled by a file in the repo, care to make a PR?

@pataquets
Copy link
Contributor Author

@smile13241324 Done on #15806.

@pataquets
Copy link
Contributor Author

BTW, I would like to ask for #9451 to be labelled as such and kept open.

@pataquets
Copy link
Contributor Author

As #9451 is reopened, I've noticed that it still has the "stale" label. AFAICT, it should not, should it?
Anything else needed in the PR? I'm afraid stalebot might target the above mentioned issue again.

@smile13241324
Copy link
Collaborator

Please check my comment in the PR it seems I have not enough rights to change the workflow.

@pataquets
Copy link
Contributor Author

Should I file a new instance of issue #9925 or could it be reopened?

If staleboting is done due to excess FRs, they could be tagged as 'PR welcome' to indicate that no maintainer is commited/interested in coding it. This would help in filtering out issues labeled "FR+PR welcome", but would leave them open to anybody to pick up. Losing FRs and their discussion sounds as valuable info and effort lost.

@TheBB @lebensterben @JAremko @syl20bnr : your opinion is appreciated. There is a PR at #15806 as suggested by @smile13241324 that went closed due to lack of feedback. I think some policing is needed in how to handle FRs, which does not mean that they should take for granted that will be done, but at least, not lost. Some smart usage of labels would help, I guess, but I can't tell for sure due to lack of info.

@pataquets
Copy link
Contributor Author

pataquets commented May 11, 2024

Happened again for same issue... #9925 (comment)
The stalebot closed issue is well relevant, but it might be completely overlooked by others interested.

@TheBB @lebensterben @JAremko @syl20bnr: Sorry to spam you again, but feedback is much needed from sb who has the decision power into this matter. As stated in the comment above, I even went thru sending a PR, which ended up closed.
Who is to ask who has the decision power into this matter? What are the drawbacks, if any?

@smile13241324
Copy link
Collaborator

I don't think this can be changed right now as far as I see I have not the rights to change it

@smile13241324 smile13241324 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2024
@McPhale
Copy link

McPhale commented Sep 16, 2024

Closing an issue due to permissions doesn't seem (to me) like a valid reason to close it

@smile13241324 smile13241324 reopened this Sep 17, 2024
@smile13241324
Copy link
Collaborator

Point taken, issue is reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants