Test this project on more platforms #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are only failing on Windows. I can't fix them but hopefully someone who uses that OS will look into this and try to fix the errors. Thanks! |
|
Do we really want this? From the readme: "This project is considered an internal tool and therefore, you shouldn't use this project in your application." As long as it works on the machine building symfony.com and our CI, I'm more than happy. |
|
OK then, let's remove Windows and macOS and let's only update the PHP versions. Thanks. |
javiereguiluz
force-pushed
the
more_tests
branch
from
ab10f54
to
e0e941f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.