Skip to content

Commit

Permalink
Merge pull request #10 from synapsestudios/8-remove-acls
Browse files Browse the repository at this point in the history
Remove explicit private ACLs, since ACLs are disallowed by default
  • Loading branch information
agerbens authored Jun 12, 2023
2 parents 6640637 + fdcaab7 commit 5a7d337
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ No modules.
| [aws_kms_key.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kms_key) | resource |
| [aws_s3_bucket.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
| [aws_s3_bucket.this-logs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
| [aws_s3_bucket_acl.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
| [aws_s3_bucket_acl.this-logs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
| [aws_s3_bucket_logging.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_logging) | resource |
| [aws_s3_bucket_public_access_block.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_public_access_block) | resource |
| [aws_s3_bucket_public_access_block.this-logs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_public_access_block) | resource |
Expand Down
5 changes: 0 additions & 5 deletions log.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ resource "aws_s3_bucket_public_access_block" "this-logs" {
restrict_public_buckets = true
}

resource "aws_s3_bucket_acl" "this-logs" {
bucket = aws_s3_bucket.this-logs.id
acl = "private"
}

resource "aws_s3_bucket_server_side_encryption_configuration" "this-logs" {
bucket = aws_s3_bucket.this-logs.id

Expand Down
5 changes: 0 additions & 5 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ resource "aws_s3_bucket_public_access_block" "this" {
restrict_public_buckets = true
}

resource "aws_s3_bucket_acl" "this" {
bucket = aws_s3_bucket.this.id
acl = "private"
}

resource "aws_s3_bucket_versioning" "this" {
bucket = aws_s3_bucket.this.id

Expand Down

0 comments on commit 5a7d337

Please sign in to comment.