Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for clang 17 and above (unsafe-buffer-usage warning results in error) #210

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix for clang 17 and above (unsafe-buffer-usage warning results in error) #210

merged 2 commits into from
Jul 23, 2024

Conversation

fknfilewalker
Copy link
Contributor

see #209

@syoyo
Copy link
Owner

syoyo commented Jul 23, 2024

set_source_files_properties cannot be invoked multiple times.

https://stackoverflow.com/questions/14192288/how-to-make-multiple-properties-valid-to-one-file-by-set-source-files-properties

You should aggregate compile_flags and pass it to single set_source_files_properties call.

@syoyo syoyo merged commit cc12740 into syoyo:release Jul 23, 2024
5 checks passed
@syoyo
Copy link
Owner

syoyo commented Jul 23, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fknfilewalker @syoyo