Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): show empty content in correct detect changes cycle #8837

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Sep 5, 2024

Before

Screen.Recording.2024-09-05.at.3.01.23.PM.mov

After

Screen.Recording.2024-09-05.at.2.55.47.PM.mov

Copy link

lumberjack-bot bot commented Sep 5, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Visit the preview URL for this PR (updated for commit b5f4158):

https://taiga-previews--pr8837-splincode-fix-list-5c0vcmen.web.app

(expires Fri, 06 Sep 2024 11:58:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 5, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
283.19KB +10%
demo/browser/vendor.(hash).js
216.46KB +10%
demo/browser/runtime.(hash).js
42KB +10%
demo/browser/styles.(hash).css
11.65KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change +5B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.96MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit f102ad3 into main Sep 6, 2024
31 checks passed
@splincode splincode deleted the splincode/fix/list branch September 6, 2024 07:52
@splincode splincode linked an issue Sep 6, 2024 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - [v4] DataList empty text is not updated correctly when items are added
3 participants