Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): Card fix paddings on mobile devices #8949

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Sep 10, 2024

Close #8939

The mobile paddings now look good in the demo. Not sure if they are applied correctly IRL on mobile device.

Copy link

lumberjack-bot bot commented Sep 10, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (4a26b1a) to head (074d24a).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8949      +/-   ##
==========================================
+ Coverage   75.68%   75.73%   +0.05%     
==========================================
  Files        1216     1216              
  Lines       19068    19071       +3     
  Branches     2091     1982     -109     
==========================================
+ Hits        14432    14444      +12     
+ Misses       4592     4587       -5     
+ Partials       44       40       -4     
Flag Coverage Δ
summary 75.73% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Sep 10, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
283.42KB +10%
demo/browser/vendor.(hash).js
216.48KB +10%
demo/browser/runtime.(hash).js
42.17KB +10%
demo/browser/styles.(hash).css
12.82KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.99MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea merged commit 12ebe35 into taiga-family:main Sep 10, 2024
29 of 30 checks passed
@waterplea
Copy link
Collaborator

Thank you for not just reporting, but finding time to actually fix the issues 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - CardLarge mobile paddings are not applied
3 participants