Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): fix minLength and maxLength properties for range in mobile calendar #9118

Conversation

LarisaGl
Copy link
Contributor

Close #8255

Copy link

lumberjack-bot bot commented Sep 20, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@LarisaGl LarisaGl changed the title fix(addon-mobile): fix minLength and maxLength properties for range i… fix(addon-mobile): fix minLength and maxLength properties for range in mobile calendar Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.31%. Comparing base (4a26b1a) to head (36b9b5a).
Report is 267 commits behind head on main.

Files with missing lines Patch % Lines
...dar-dropdown/mobile-calendar-dropdown.component.ts 48.00% 13 Missing ⚠️
.../calendar-range/calculate-disabled-item-handler.ts 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9118      +/-   ##
==========================================
- Coverage   75.68%   75.31%   -0.38%     
==========================================
  Files        1216     1232      +16     
  Lines       19068    19312     +244     
  Branches     2091     2077      -14     
==========================================
+ Hits        14432    14545     +113     
- Misses       4592     4725     +133     
+ Partials       44       42       -2     
Flag Coverage Δ
summary 75.31% <51.35%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Sep 20, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
288.02KB (+41B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.14KB +10%
demo/browser/runtime.(hash).js
42.71KB +10%
demo/browser/styles.(hash).css
16.17KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +40B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.14MB (+203B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit c84dd39 into taiga-family:main Sep 30, 2024
36 checks passed
This was referenced Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - InputDateRange + [minLength] / [maxLength] has bad support for MobileCalendar
3 participants