Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Hint add mobile behavior #9547

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(core): Hint add mobile behavior #9547

wants to merge 2 commits into from

Conversation

waterplea
Copy link
Collaborator

Fixes #

@waterplea waterplea marked this pull request as ready for review October 18, 2024 14:49
@waterplea waterplea requested a review from a team as a code owner October 18, 2024 14:49
@waterplea waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 18, 2024 14:49
Copy link

lumberjack-bot bot commented Oct 18, 2024

Failed tests ❌

Before (main) ← Diff → After (local)

tests-layout-navigation-Navigation-Show-hint-in-aside-chromium/03-navigation.diff.png
tests-addon-charts-line-ch-ae543-eChart-should-not-show-hint-chromium/01-line-chart.diff.png
tests-addon-charts-pie-cha-99a56-uld-be-show-hints-on-charts-chromium/01-pie-chart-with-label--hover-1.diff.png
tests-legacy-primitive-tex-513f9-n-primitive-textfield-works-chromium/01-hint.diff.png
tests-kit-slider-slider-Sl-c1006-el-increase-value-by-1-step-chromium/06-slider-ngModel-increase-by-1-step.diff.png
tests-kit-slider-slider-Sl-2a586-l-increase-value-by-2-steps-chromium/07-slider-ngModel-increase-by-2-step.diff.png
tests-kit-slider-slider-Sl-d6272-el-decrease-value-by-1-step-chromium/05-slider-ngModel-decrease-by-1-step.diff.png
tests-core-hint-hint-TuiHi-02adb-tom-viewport-width-is-256px-chromium/02-hint-manual-direction-left-bottom-and-width-256.diff.png
tests-core-hint-hint-TuiHi-09580-ght-viewport-width-is-256px-chromium/02-hint-manual-direction-bottom-right-and-width-256.diff.png
tests-core-hint-hint-TuiHi-18962-om-viewport-width-is-1280px-chromium/02-hint-manual-direction-bottom-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-2d6f5-om-viewport-width-is-1280px-chromium/02-hint-manual-direction-left-bottom-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-45ac6-ght-viewport-width-is-256px-chromium/02-hint-manual-direction-right-and-width-256.diff.png
tests-core-hint-hint-TuiHi-4d4a3-top-viewport-width-is-256px-chromium/02-hint-manual-direction-right-top-and-width-256.diff.png
tests-core-hint-hint-TuiHi-582fc-op-viewport-width-is-1280px-chromium/02-hint-manual-direction-right-top-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-60123-eft-viewport-width-is-256px-chromium/02-hint-manual-direction-left-and-width-256.diff.png
tests-core-hint-hint-TuiHi-69437-ht-viewport-width-is-1280px-chromium/02-hint-manual-direction-bottom-right-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-6e01b-top-viewport-width-is-256px-chromium/02-hint-manual-direction-left-top-and-width-256.diff.png
tests-core-hint-hint-TuiHi-8707b-ft-viewport-width-is-1280px-chromium/02-hint-manual-direction-left-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-9688a-ht-viewport-width-is-1280px-chromium/02-hint-manual-direction-top-right-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-991d4-ft-viewport-width-is-1280px-chromium/02-hint-manual-direction-bottom-left-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-b0e58-eft-viewport-width-is-256px-chromium/02-hint-manual-direction-top-left-and-width-256.diff.png
tests-core-hint-hint-TuiHi-b20a5-top-viewport-width-is-256px-chromium/02-hint-manual-direction-top-and-width-256.diff.png
tests-core-hint-hint-TuiHi-b23c0-op-viewport-width-is-1280px-chromium/02-hint-manual-direction-left-top-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-c321c-op-viewport-width-is-1280px-chromium/02-hint-manual-direction-top-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-db0fa-eft-viewport-width-is-256px-chromium/02-hint-manual-direction-bottom-left-and-width-256.diff.png
tests-core-hint-hint-TuiHi-db8d4-om-viewport-width-is-1280px-chromium/02-hint-manual-direction-right-bottom-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-e13d2-tom-viewport-width-is-256px-chromium/02-hint-manual-direction-bottom-and-width-256.diff.png
tests-core-hint-hint-TuiHi-e5f23-ft-viewport-width-is-1280px-chromium/02-hint-manual-direction-top-left-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-ec286-tom-viewport-width-is-256px-chromium/02-hint-manual-direction-right-bottom-and-width-256.diff.png
tests-core-hint-hint-TuiHi-fee05-ht-viewport-width-is-1280px-chromium/02-hint-manual-direction-right-and-width-1280.diff.png
tests-core-hint-hint-TuiHi-ff904-ght-viewport-width-is-256px-chromium/02-hint-manual-direction-top-right-and-width-256.diff.png
tests-core-hint-hint-TuiHint-Tooltip-horizontal-direction-chromium/04-tooltip-left.diff.png
tests-core-hint-hint-TuiHint-Tooltip-vertical-direction-chromium/05-tooltip-bottom.diff.png
tests-core-hint-hint-TuiHint-false-mode-hint-with-delay-chromium/03-hint-mode-false-tuiHintShowDelay-1000-wait-500.diff.png
tests-core-hint-hint-TuiHint-TuiHint-works-chromium/01-hint.diff.png
tests-core-hint-hint-TuiHint-false-mode-hint-without-delay-chromium/03-hint-mode-false-tuiHintShowDelay-0.diff.png
tests-core-hint-hint-TuiHint-true-mode-hint-with-delay-chromium/03-hint-mode-true-tuiHintShowDelay-1000-wait-500.diff.png
tests-core-hint-hint-TuiHint-true-mode-hint-without-delay-chromium/03-hint-mode-true-tuiHintShowDelay-0.diff.png

(updated for commit 0e5be49)

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Visit the preview URL for this PR (updated for commit 0e5be49):

https://taiga-previews--pr9547-tooltip-6b45gpez.web.app

(expires Sat, 19 Oct 2024 14:59:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 18, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
296.64KB (+1.01KB +0.34%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
255.66KB +10%
demo/browser/runtime.(hash).js
43.23KB +10%
demo/browser/styles.(hash).css
19.31KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +1.01KB +0.16%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.16MB (+1.01KB +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants