Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): enhance nextTxId logics in DelegateOwner #17718

Merged
merged 15 commits into from
Jul 21, 2024
Merged

feat(protocol): enhance nextTxId logics in DelegateOwner #17718

merged 15 commits into from
Jul 21, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 2, 2024 •
edited
Loading

This PR modifies DelegateOwner to skip nextTxId verification when call.txId is zero, enabling DAO proposals for parallel L2 transactions.

@dantaik dantaik marked this pull request as ready for review July 2, 2024 09:28
@dantaik dantaik enabled auto-merge July 2, 2024 09:29
@dantaik dantaik disabled auto-merge July 2, 2024 15:40
@dantaik dantaik marked this pull request as draft July 2, 2024 15:40
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jul 19, 2024 •
edited
Loading

chore(protocol): add SendMessageToDelegateOwner.s.sol script

Generated at commit: da508350f0cf10d6bebf7663e6c903f70001f138

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik marked this pull request as ready for review July 19, 2024 06:58
@dantaik dantaik requested a review from Brechtpd July 19, 2024 07:00
@dantaik dantaik changed the title chore(protocol): add SendMessageToDelegateOwner.s.sol script feat(protocol): enhance nextTxId logics in DelegateOwner Jul 19, 2024
@dantaik dantaik requested a review from adaki2004 July 19, 2024 07:48
@dantaik dantaik added this pull request to the merge queue Jul 21, 2024
Merged via the queue into main with commit 85b2cad Jul 21, 2024
6 checks passed
@dantaik dantaik deleted the test_delegate_owner branch July 21, 2024 04:33
@taiko-kitty taiko-kitty mentioned this pull request Jul 21, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha