Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): name address manager param clearer #17806

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 17, 2024

Given that we have two address manages (shared and rollup), naming parameters this way is less confusing.

@dantaik dantaik marked this pull request as ready for review July 17, 2024 01:38
Copy link

openzeppelin-code bot commented Jul 17, 2024

refactor(protocol): name address manager param clearer

Generated at commit: 73d4c4ebe5bf14a2cf6bab19e9cb18b89894bc75

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik requested a review from smtmfft July 17, 2024 04:49
@dantaik dantaik enabled auto-merge July 17, 2024 04:50
@swarna1101
Copy link
Contributor

this looks good, and the parameter naming is much more clearer now

@dantaik dantaik added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 1d5a6ff Jul 17, 2024
5 checks passed
@dantaik dantaik deleted the name_address_manager branch July 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants