feat(protocol): prepare ontake fork to support new params & metadata
#17679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): prepare
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
2 2 0 8 41 53 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
dantaik
changed the title
dantaik
changed the title
dantaik
changed the title
ontake fork to support new params & metadata
dantaik
commented
Jul 2, 2024
Comment on lines
+8
to
+13
| interface IProposerAccess { | ||
| /// @notice Checks if a proposer can propose block in the current Ethereum block. | ||
| /// @param _proposer The proposer. | ||
| /// @return true if the proposer can propose blocks, false otherwise. | ||
| function isProposerEligible(address _proposer) external view returns (bool); | ||
| } |
There was a problem hiding this comment.
We can change it later. I think we just care about the permission checking function rather than the registration logics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(protocol): allow contract proposers to use calldata as well
feat(protocol): add preconfirmation support based on Brecht's PR (with some renaming) to implement #14793
feat(protocol): add
proposeBlock2in TaikoL1.sol andapprove2in GuardianProver.sol to be used post a forkrefactor(protocol): avoid writing livenessBond to storage to remove unnecessary SSTORE and SLOAD.
refactor(protocol): enable AddressManager to cache address(0) without reading from storage
END_COMMIT_OVERRIDE
TODO