Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): preconf: use ontake fork and organize files differently #18235

Merged
merged 11 commits into from
Oct 11, 2024
Merged

feat(protocol): preconf: use ontake fork and organize files differently #18235

merged 11 commits into from
Oct 11, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 11, 2024 •
edited
Loading

  • Use ITaikoL1 from 1.9.0 release
  • restructure/renamed files
  • make BLSSignature a library
  • Remove code that verifies preconf violation
  • add IPreconfViolationVerifier interface

@dantaik dantaik marked this pull request as ready for review October 11, 2024 06:10
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 11, 2024 •
edited
Loading

feat(protocol): preconf: use ontake fork and organize files differently

Generated at commit: 96cc377812203ca6f0deba7ff6a3a293ca306998

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title feat(protocol): improve preconf codebase feat(protocol): precof - organize files differently Oct 11, 2024
@dantaik dantaik changed the title feat(protocol): precof - organize files differently feat(protocol): precof - use ontake fork and organize files differently Oct 11, 2024
@dantaik dantaik changed the title feat(protocol): precof - use ontake fork and organize files differently feat(protocol): preconf: use ontake fork and organize files differently Oct 11, 2024
@dantaik dantaik merged commit 592384a into preconf_migrate_1 Oct 11, 2024
6 checks passed
@dantaik dantaik deleted the preconf_migrate_2 branch October 11, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dantaik