Sort class attribute on components and custom elements in Astro
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original implementation didn't include support for sorting classes on components (maybe was early enough to not need it?). Do you see any problems with supporting this? |
Hello! Unlike Vue for example, it's not a built-in pattern in Astro to have a You also probably want to add In both cases, I believe it should be supported, definitely seems useful! |
Princesseuh
approved these changes
Mar 2, 2023
reinink
changed the title
class attribute on Astro componentsclass attribute on components and custom elements in Astro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128