Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make font settings propagate into buttons, inputs, etc. #10940

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Make font settings propagate into buttons, inputs, etc. #10940

merged 3 commits into from
Apr 28, 2023

Conversation

dcastil
Copy link
Contributor

@dcastil dcastil commented Apr 4, 2023

In Tailwind CSS v3.3 a feature was introduced to add font-feature-settings and font-variant-settings to the font-family config: https://tailwindcss.com/blog/tailwindcss-v3-3#configure-font-variation-settings-for-custom-font-families

These values are overriden by the user agent stylesheet for buttons, inputs, etc.

Since Tailwind CSS overrides the default behavior for the font-family value, I think it makes sense to add the same change for font-feature-settings and font-variant-settings.

@adamwathan
Copy link
Member

Makes perfect sense, thanks for this one!

@adamwathan
Copy link
Member

@RobinMalfait @thecrypticace @reinink — good to merge this after updating the tests to account for the change in Preflight 👍

@RobinMalfait RobinMalfait changed the base branch from master to 3.3 April 28, 2023 07:50
@RobinMalfait RobinMalfait merged commit 1f1a6fa into tailwindlabs:3.3 Apr 28, 2023
@dcastil dcastil deleted the patch-1 branch April 28, 2023 08:45
thecrypticace pushed a commit that referenced this pull request Jul 13, 2023
* Make font settings propagate into buttons, inputs, etc.

* update source-maps test due to preflight change

* update changelog

---------

Co-authored-by: Robin Malfait <[email protected]>
thecrypticace pushed a commit that referenced this pull request Jul 13, 2023
* Make font settings propagate into buttons, inputs, etc.

* update source-maps test due to preflight change

* update changelog

---------

Co-authored-by: Robin Malfait <[email protected]>
thecrypticace pushed a commit that referenced this pull request Jul 13, 2023
* Make font settings propagate into buttons, inputs, etc.

* update source-maps test due to preflight change

* update changelog

---------

Co-authored-by: Robin Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants