Provide a default tracking with Font Size config #1915
Conversation
|
I like this idea a lot! My only hesitation is that bumping this up to 3 unnamed positional parameters is getting into "not obvious" territory in terms of what things do. I think it's probably fine but I wonder if it would be worth introducing an object syntax at this point so things are more clear, like: module.exports = {
theme: {
// ...
fontSize: {
sm: ['14px', { lineHeight: '20px', letterSpacing: '0.01em' }],
// ...
}
}
}What do you think, is it too verbose for the people who would want this feature or is it worth it for the extra clarity? |
|
I would vote for clarity in 10/10 cases. Better for documenting, even better because somebody wouldn't even need to look into the docs to know what the code above is doing. |
|
Sounds good. The one issue I see is that we will have to support both the current 2-parameter syntax and this new object syntax, which might be confusing in the documentation. |
Extend the configuration syntax to allow specifying letterSpacing
alongside lineHeight in the fontSize config.
The syntax looks like
```
module.exports = {
theme: {
// ...
fontSize: {
sm: ['14px', { lineHeight: '20px', letterSpacing: '0.01em' }],
// ...
}
}
}
```
Also retains backwards compatibility with array syntax of 1.3
|
Changed to the suggested syntax |
|
Just wanted to make a PR and came across this, can't wait for it to be released 🎉 |
|
@adamwathan Sorry to bother you, but are there plans for this to be included in any upcoming release? |
|
@Larsklopstra Pinging you to let you know this has been released |
We can already configure line-height with font sizes, but this allows
us to also specify the default tracking for these sizes too.
This can be overwritten with tracking utilities.
I asked here but got no response: #1874