Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate atrules without children #8122

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

thecrypticace
Copy link
Contributor

We assumed that all At Rule nodes had children. Including ones that do not and should not — for example @import url(…);. Since this is not the case we’ll skip adding children for nodes that don’t have any.

Fixes #8103

thecrypticace and others added 2 commits April 15, 2022 12:18
We assumed that all At Rule nodes had children. Including ones that do not and should not — for example `@import url(…);`. Since this is not the case we’ll skip adding children for nodes that don’t have any.

Co-authored-by: Jordi Marimon Palarea <[email protected]>
@thecrypticace thecrypticace merged commit e5ed08b into master Apr 15, 2022
@thecrypticace thecrypticace deleted the fix/at-rules-without-children branch April 15, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate @import CSS rules cause undefined behaviour
1 participant