Only check selectors containing apply candidates for circular dependencies #8222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given a two rule like
html.dark .a, .b { … }
andhtml.dark .c { @apply b }
we would see.dark
in both the base rule and the rule being applied and consider it a circular dependency. However, the selectorshtml.dark .a
and.b
should be considered on their own and as a result not introduce a circular dependency.This better matches the user’s mental model that the selectors are just two definitions sharing the same properties.
Fixes #7844