polyglot-scala: Added default value for pom property modelversion (4.0.0) #158
Conversation
It is more than expected, that this version will not change in the near future.
|
Merged with f765ca4 |
|
I merged this but I am getting test failures.. wanna have a look @lefou ? |
|
Why do you dropped my commits? I see only my github name in your commit message. |
|
@mosabua I can reproduce the failing tests. Must have overlooked it, sorry. I'll create another PR. |
This commit completes pull request takari#158
|
I screwed up the merging and it was too painful on the other PR due to conflicts .. so I thought I just commit this normal on master .. it was just easier late at night yesterday .. sorry |
|
Thanks for telling me. That's OK. I'd be glad to offer my help. I think, I have a fairly good understanding of polyglot-maven and use it in several projects. With commit access I could merge approved or trivial commits directly. WDYT? |
|
Sure.. you would have to sign the Takari CLA .. did you do that already? |
|
I'm not sure, I think not. Where can I find it? |
It is more than expected, that this version will not change in the near future.