Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'make release' should tag the commit #282

Closed
tartley opened this issue Oct 15, 2020 · 1 comment
Closed

'make release' should tag the commit #282

tartley opened this issue Oct 15, 2020 · 1 comment
Labels
process Changes in our development process, CI, package building, releases, etc

Comments

@tartley
Copy link
Owner

tartley commented Oct 15, 2020

As is described in README-hacking

  • Specifically, tag with the current value of __version__. Fail if that tag already exists.
    Possibly we should be creating annotated tags (see below):

    git tag -a -m "" $version
    
  • Push the tag to origin. To do this for a commit which is already pushed, we might need::

    git push --follow-tags
    

    --tags pushes all tags on every branch, which is probably not desired. e.g. some will be private development status, some might be on distant or unreachable branches, etc.

    --follow-tags was designed to fix this, it only sends tags on ancestors of the current commit, and also only sends annotated tags.

@tartley tartley added the process Changes in our development process, CI, package building, releases, etc label Oct 15, 2020
@tartley tartley changed the title 'make release' should tag & push 'make release' should tag the commit Oct 15, 2020
@tartley
Copy link
Owner Author

tartley commented Jun 15, 2022

this is a bad idea, tags should be written before doing the build

@tartley tartley closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Changes in our development process, CI, package building, releases, etc
Projects
None yet
Development

No branches or pull requests

1 participant