Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed complex orders + error messages #133

Merged
merged 4 commits into from
Mar 10, 2024
Merged

Fixed complex orders + error messages #133

merged 4 commits into from
Mar 10, 2024

Conversation

rekroeg
Copy link
Contributor

@rekroeg rekroeg commented Mar 8, 2024

Description

  • Example for complex orders is not working because the preflight_id and complex_order_id are returned as int
  • For missing stop_triggers the error messages do not contain "code"

@Graeme22
Copy link
Contributor

Graeme22 commented Mar 9, 2024

Thanks for this! Could you use typing.Union instead of | so this is compatible with older Python versions?

@rekroeg
Copy link
Contributor Author

rekroeg commented Mar 9, 2024

Sure. I made another commit.

@Graeme22 Graeme22 marked this pull request as ready for review March 10, 2024 00:28
@Graeme22 Graeme22 merged commit c029fcd into tastyware:master Mar 10, 2024
1 check failed
@Graeme22
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graeme22 Graeme22 Graeme22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekroeg @Graeme22