fix(bundler/wix): use product name to generate UpgradeCode for MSI
#10967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade code generation was changed due to an accidental regression in #9375. Previously `UpgradeCode` was calculated using the main binary name which was `<product_name>.exe`, but #9375 changed the default main binary name to `<cargo-crate-name>.exe` and thus a different UpgradeCode was generetad. This PR reverts this change to use product name for `UpgradeCode` generation.
Package Changes Through 4968397There are 2 changes which include tauri-bundler with prerelease, tauri-cli with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
added a commit
that referenced
this pull request
Sep 11, 2024
amrbashir
added a commit
that referenced
this pull request
Sep 11, 2024
FabianLars
approved these changes
Sep 12, 2024
lucasfernog
approved these changes
Sep 12, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade code generation was changed due to an accidental regression in #9375. Previously
UpgradeCodewas calculated using the main binary name which was<product_name>.exe, but #9375 changed the default main binary name to<cargo-crate-name>.exeand thus a different UpgradeCode was generetad.This PR reverts this change to use product name for
UpgradeCodegeneration.