@lifetime annotation + simplified implicit lifetime dependencies #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section was a distraction. Changing the position of `dependsOn` for initializers is not something we need to consider initially.
tbkka
reviewed
Aug 1, 2024
| - is non-BitwiseCopyable and has an explicit `borrowing`, or `inout` convention | ||
|
|
||
| In this case, the compiler will infer a dependency on the unique argument identified by these conditions. | ||
| **For methods where the return value is nonescapable and self is not the same type as the result**, we will infer a dependency against self, depending on the mutation type of the function. Note that this is not affected by the presence, type, or modifier of any other arguments to the method. |
There was a problem hiding this comment.
What if self is the same type as the result? I'm not sure I understand why you're excepting that case.
I suggest adding a sentence in here somewhere to clarify that these rules can result in multiple lifetime dependencies. In particular, for a method T.foo(:U, :U) -> U, the result will depend on self and both arguments.
Added the same-type inference rule.
atrick
force-pushed
the
lifetime-dependency
branch
from
c6131aa
to
ac43daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New alternative considered: @Lifetime annotation
Simplified implicit lifetime dependencies