Editorial: Add Iterator Record type
#2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
reviewed
Nov 29, 2021
ExE-Boss
force-pushed
the
editorial/add-iterator-record-type
branch
from
e1987d5
to
623951d
Compare
jmdyck
reviewed
Dec 8, 2021
There was a problem hiding this comment.
In 27.1.4.3 "Properties of Async-from-Sync Iterator Instances", the description for [[SyncIteratorRecord]] says
A Record, of the type returned by GetIterator, representing ...
That could be changed to
An Iterator Record representing ...
Other than that, looks good to me.
|
Partially resolves #2486. |
bakkot
reviewed
Dec 28, 2021
jmdyck
previously requested changes
Dec 29, 2021
There was a problem hiding this comment.
I just noticed that you could also change the 'type' of the _iteratorRecord_ parameter from unknown to an Iterator Record in each of:
- IteratorBindingInitialization
- IteratorDestructuringAssignmentEvaluation
- ForIn/OfBodyEvaluation
- PerformPromiseAll
- PerformPromiseAllSettled
- PerformPromiseAny
- PerformPromiseRace
And similarly for _syncIteratorRecord_ in CreateAsyncFromSyncIterator.
syg
approved these changes
Feb 16, 2022
bakkot
added
the
ready to merge
Co-authored-by: ExE Boss <[email protected]> Co-authored-by: Michael Dyck <[email protected]>
ljharb
force-pushed
the
editorial/add-iterator-record-type
branch
from
2a943e6
to
85d910c
Compare
ljharb
dismissed
jmdyck’s stale review
per editor call, this can be done in a followup
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Apr 18, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Apr 21, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Apr 22, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Apr 28, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 6, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 16, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 30, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Sep 3, 2022
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
<dfn>and<emu‑table>for “Iterator Records”.Part of #2486