-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: add Iterator Helpers #3395
base: main
Are you sure you want to change the base?
Conversation
7879f32
to
0bf3656
Compare
@@ -6956,6 +6996,28 @@ <h1> | |||
</emu-alg> | |||
</emu-clause> | |||
|
|||
<emu-clause id="sec-getiteratorflattenable" type="abstract operation"> | |||
<h1> | |||
GetIteratorFlattenable ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to come up with a better name for this AO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was about GetIteratorFlattenable
(it's no longer displaying under the appropriate line in the diff view).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right on the conversation view, at least
2db9b31
to
78c9237
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b7e5f5f
to
189e3d6
Compare
2255ce1
to
0cb2376
Compare
FYI we're having a relevant editorial discussion here: tc39/proposal-joint-iteration#30 |
fb4e134
to
fc4354b
Compare
also split up the steps and add an assert for better understandability
The spec's convention is: when you have a set of sections that define the properties of some intrinsic object, first do the properties whose keys are strings, in alphabetical order, then do the properties whose keys are symbols, in alphabetical order. (The only exception is in "Properties of the RegExp Prototype Object", where the symbol-keyed-properties are interleaved with the string-keyed-properties.)
... as well known intrinsics. (You'll need to fill in the descriptions.)
All other "Properties of the Foo Constructor" sections start with a <p><ul> where, at the very least, you say what the constructor's [[Prototype]] is.
322876c
to
380047c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to be missing changes to CreateIteratorFromClosure to add a 4th argument? (present in the proposal spec)
@tc39/ecma262-editors Do we want to make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I no longer think we should rename [[UnderlyingIterators]]
now, since it would also involve changing its handling; we can do that in the followup.
https:/tc39/proposal-iterator-helpers