Editorial: Pass epoch nanoseconds to FormatDateTimePattern #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
approved these changes
Jul 1, 2024
|
(Somehow my review gets a green checkmark, despite not being a reviewer for ecma402. Please do have a real reviewer look at this.) |
|
LGTM! |
ben-allen
approved these changes
Jul 12, 2024
ben-allen
force-pushed
the
FormatDateTimePattern-nanoseconds
branch
from
ff4e362
to
1780069
Compare
|
This has been merged, not closed -- had to resolve merge conflicts via command line in a way that effectively merged this PR, but under a different commit number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the Temporal integration and makes FormatDateTimePattern an infallible operation.