Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

ExportedNames incomplete for NameSpaceExport production #9

Closed
wants to merge 1 commit into from

Conversation

spectranaut
Copy link
Collaborator

Hi @jdalton, I'm pretty sure this is a necessary addition to the ExportedNames algorithm, can you review?

Presently, the ExportedNames has a rule for the production NameSpaceExport here:

ExportFromClause : NameSpaceExport
    Return the ExportedNames of NameSpaceExport. 

But no way to further evaluate the ExportedNames of NameSpaceExport.

I believe, because of the chain of production (and the line, Return the ExportedNames of ExportFromClause above), we can replace these lines with:

NameSpaceExport : * as IdentifierName
    Return a List containing the StringValue of IdentifierName.

@spectranaut spectranaut changed the title ExportedNames incomplete ExportedNames incomplete for NameSpaceExport production Mar 15, 2018
@jdalton
Copy link
Member

jdalton commented Mar 15, 2018

Hi @spectranaut!

You are totally more familiar with the formal spec text process than myself. I used to know the ins and outs back in the day, but now with so much meta/shorthand/composition spec syntax it's hard for me to follow. The PR looks good to me, but I'll defer to @bterlson for the real review.

@spectranaut spectranaut closed this Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants