Normative: Upper limit on rounding increments #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
- Coverage 94.97% 94.95% -0.02%
==========================================
Files 20 20
Lines 10903 10825 -78
Branches 1996 1959 -37
==========================================
- Hits 10355 10279 -76
Misses 487 487
+ Partials 61 59 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Jan 17, 2023
Previously in a few cases (calendar units in Duration) the value for the roundingIncrement option had no upper limit, other than having to be finite. These tests cover a normative change limiting it to 1e9. Normative PR: tc39/proposal-temporal#2480
ptomato
commented
Jan 17, 2023
Comment on lines
-210
to
+212
| 1. If _increment_ < *1*<sub>𝔽</sub>, throw a *RangeError* exception. | ||
| 1. Return truncate(ℝ(_increment_)). | ||
| 1. Let _integerIncrement_ be truncate(ℝ(_increment_)). | ||
| 1. If _integerIncrement_ < 1 or _integerIncrement_ > 10<sup>9</sup>, throw a *RangeError* exception. | ||
| 1. Return _integerIncrement_. |
There was a problem hiding this comment.
@gibson042 I thought you might be particularly interested to note this change since you did an earlier similar change to check the range for fractionalSecondDigits after truncating it; now that we have an upper limit, it matters here too.
|
Tests for this are in tc39/test262#3770 |
gibson042
approved these changes
Jan 18, 2023
justingrant
approved these changes
Jan 18, 2023
Rounding increments are usually limited. In a few cases (years, months, weeks, and days for Temporal.Durations), they were previously only limited by being required to be finite. This introduces a limit of 1e9 for these previously unlimited cases. 1e9 fits in a 32-bit integer, to make things simpler for implementations, but is clearer to explain in end-user documentation than UINT32_MAX.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 1, 2023
Previously in a few cases (calendar units in Duration) the value for the roundingIncrement option had no upper limit, other than having to be finite. These tests cover a normative change limiting it to 1e9. Normative PR: tc39/proposal-temporal#2480
ptomato
added a commit
to tc39/test262
that referenced
this pull request
Feb 1, 2023
Previously in a few cases (calendar units in Duration) the value for the roundingIncrement option had no upper limit, other than having to be finite. These tests cover a normative change limiting it to 1e9. Normative PR: tc39/proposal-temporal#2480
ptomato
force-pushed
the
2458-limit-rounding-increment
branch
from
2e091af
to
2728067
Compare
|
This change reached consensus at the 2023-01-31 TC39 plenary meeting. Test262 tests have already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rounding increments are usually limited. In a few cases (years, months, weeks, and days for Temporal.Durations), they were previously only limited by being required to be finite. This introduces a limit of 1e9 for these previously unlimited cases.
1e9 fits in a 32-bit integer, to make things simpler for implementations, but is clearer to explain in end-user documentation than UINT32_MAX.
Closes: #2458