Temporal: Use strings in [[Calendar]] and [[TimeZone]] slots to represent builtin calendars and time zones #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
temporal-1808
branch
from
9b303c8
to
87ed3b6
Compare
Ms2ger
approved these changes
Apr 5, 2023
Now.timeZoneId() returns a string so that it can be used to construct objects that have the builtin time zone behaviour. Normative PR: tc39/proposal-temporal#2482
Has several effects on existing tests: - Remove PlainTime from various tests that extract a Temporal.Calendar instance from another Temporal object. - Remove Temporal.PlainTime.prototype.calendar property. - Remove calendar property from object returned from Temporal.PlainTime.prototype.getISOFields(). - Ignore calendar annotation when converting ISO string to PlainTime. Normative PR: tc39/proposal-temporal#2482
…ndar This is the replacement of the old API with the new API. Semantics will be corrected in the following commit. Normative PR: tc39/proposal-temporal#2482
In several tests involving custom calendars, we need to change the implementation of dateFromFields/monthDayFromFields/yearMonthFromFields so that the returned object gets the receiver as its calendar after chaining up to the builtin implementation. Normative PR: tc39/proposal-temporal#2482
Compare semantics for custom calendars that _don't_ extend Temporal.Calendar (and therefore don't have the internal slot) use the value of the .id property, instead of calling toString(). Normative PR: tc39/proposal-temporal#2482
This is the replacement of the old API with the new API, .timeZoneId and .getTimeZone(). Semantics will be corrected in the following commit. Normative PR: tc39/proposal-temporal#2482
Compare semantics for custom time zones that _don't_ extend Temporal.TimeZone (and therefore don't have the internal slot) use the value of the .id property, instead of calling toString(). Normative PR: tc39/proposal-temporal#2482
|
Thanks. I'm about to push an update to the corresponding proposal-temporal PR that resolves all the comments there. I'll merge this now, so that it can pull in a test262 update and run against these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-temporal#1808 for motivation and tc39/proposal-temporal#2482 for the normative PR that was approved at the January-February 2023 TC39 plenary.
Separated into several commits for ease of review; I'd recommend reviewing it commit by commit and skimming over the commits that mostly consist of straightforward search-and-replace.