-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Being stuck on Rust 1.61.0 is unacceptable #127
Comments
Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are rapidly approaching (really, have passed already several times over) the point where it does not make sense to continue pinning a version, even for the convenience of anyone's security processes.
core::ffi::CStr
. It allows removing dependencies (core_cstr
), so it reduces the amount of code that anyone has to worry about in the supply chain, but by pinning to 1.61 we are losing that opportunity.std::thread::scope
. It allows removing a large dependency in the build system forpgx-pg-sys
, therayon
dependency which brings in about a dozen other crates, so it significantly reduces the amount of code that anyone has to worry about in the supply chain, but by pinning to 1.61 we are losing that opportunity.#[link_section]
is not independently detected asunsafe
until then, only#[no_mangle]
but that is, again, still an unsupported version in security terms, so realistically, moving from an unsupported version to an unsupported version is not really acceptable.cargo pgx
for the specific pinned rustc version. These pointless rebuilds slow down every single patch I might write for PL/Rust. It can easily consume an hour or more on pure faffing about when switching back and forth, partly assisted by sometimes forgetting and only hitting the secondary issues caused by not doing so, thus having to debug it, and only then remembering to rebuild and reinstall, etc. This is already a test suite that takes too long to run and debug, this makes it even more unconscionable.unsafe
detection upstream in rustc and submitting patches for what we find, and that would only come to stable ~2 versions after it merges.std::backtrace::Backtrace
. It's intended to be a key component of newer, more sophisticated and better-scoped error-handling in Rust. Even if it's mostly going to be a diagnostic improvement, it's a lot to not have.The text was updated successfully, but these errors were encountered: