Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Contacts picker by the Element iOS one #638

Closed
phloux opened this issue Jul 28, 2022 · 1 comment
Closed

Replace Contacts picker by the Element iOS one #638

phloux opened this issue Jul 28, 2022 · 1 comment
Assignees
Labels

Comments

@phloux
Copy link

phloux commented Jul 28, 2022

Currently, Element iOS and Tchap iOS have not the same contacts picker.
We use a specific one for Tchap, but we should use the Element one.

And we also have a duplicate dataSource for this. So we need to remove the Tchap specific dataSource currently called ContactsDataSourceTchap

@phloux phloux added the iOS label Jul 28, 2022
@giomfo
Copy link
Contributor

giomfo commented Jul 29, 2022

This picker is used in multiple cases:

  • start a new DM

  • invite a new room member

  • The Element picker displays a tile to prompt the user to access the contact book, we will hide this tile in Tchap in all cases

  • Hide the contact book settings from the application settings

image

  • in case of a new DM, we will hide in Tchap the "invite friends.." button

image

  • in case of the invite of new room member, we will keep display the option "share invite link". The handling of this option should be improved in Element-iOS see

image

@phloux phloux self-assigned this Aug 4, 2022
phloux pushed a commit that referenced this issue Aug 17, 2022
Replace Contacts picker by the Element iOS one (#638)
@giomfo giomfo closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants