[WIP] Add officialstm32 eeprom write API functions and wrap in conditionals #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(save-image) seems to work but (load-image) crashes my bluepill. All help would be appreciated |
|
OK I'll take a look at it this afternoon. |
|
I've had a look at your code. However, I can't work out where the EEPROM library is that you're using. I have the official STM32 core version 1.9.0 installed, but the EEPROM library in libraries just looks like the original Arduino one. Where did you find the example code such as: The key question is: how much emulated EEPROM does it provide? With the current settings uLisp assumes there are 10240 bytes, and it uses a minimum of 512 for the symbol table. |
|
I saw the function defs in |
|
Looking closer, the actual implementation seems to be in |
|
I can't spot anything wrong with your code - I think it's unnecessary to clear the buffer, but it can't do any harm. I'd be interested to know what the value of E2END is; can you insert: |
|
It gives me From the /*
* FLASH_PAGE_SIZE is not defined for STM32F2xx, STM32F4xx and STM32F7xx
* Could be redefined in variant.h or using build_opt.h
* Warning: This is not the sector size, only the size used for EEPROM
* emulation. Anyway, all the sector size will be erased.
* So pay attention to not use this sector for other stuff.
*/
#define FLASH_PAGE_SIZE ((uint32_t)(16*1024)) /* 16kB page */
#endif
#define E2END (FLASH_PAGE_SIZE - 1)
#endif |
|
Try changing: to: |
|
With the change |
|
Are we overwriting something or ... ? I can re-program it from Arduino using the STM32 ST-Link V2 STM32CubeProgrammer SWD . |
This program leaves it in a good state and outputs |
|
Sorry, I'm not sure what else to suggest. |
|
Thank you. I'll keep debugging. Currently trying to produce a minimal saveimage/loadimage and see why it bugs out. writes seem to be fine at least. |
|
Oh christ, I found the error! Once I cut down the code to being a very small portion everywhere I started staring at FlashReadByte and ... I was sending in the pointer (addr) instead of its value to Corrected to |
|
OK, one small issue. It seems the eeprom does not persist over reboots. I flash the ulisp image with the boot0 jumper set to 1, then set it to 0, reset the board and connect over serial to a ulisp prompt. Here I run which writes a bunch of stuff. If I run (load-image) without resetting the board it works as well. |
#include <EEPROM.h>
#define DATA_LENGTH E2END
void setup() {
Serial.begin(115200);
while(!Serial) {;;}
Serial.write("Old contents of buffer pre-reset are:\n");
eeprom_buffer_fill();
for (uint16_t i=0; i < E2END; i++){
uint8_t d = eeprom_buffered_read_byte(i);
Serial.print("flash-read-from-buffer: 0x");Serial.print(i, HEX); Serial.print("->0x"); Serial.println(d,HEX);
}
// Fill the EEPROM buffer in memory with data
for (uint16_t i = 0; i < DATA_LENGTH; i++) {
eeprom_buffered_write_byte(i, (uint8_t) 255);
}
// Copy the data from the buffer to the flash
eeprom_buffer_flush();
// Copy the data from the flash to the buffer
eeprom_buffer_fill();
// Print the last byte of the current buffer
Serial.println("Wrote 0xFF to all available bytes in memory, last byte was:");
Serial.println(eeprom_buffered_read_byte(DATA_LENGTH - 1));
}
void loop() {}works across reboots. Weird. |
|
It works! Somewhat! I had to add the EEPROM offset that is used for roger's core's eeprom emu as a define so the stm32 eeprom layer picks it up for the API.
The issue seems to be that if we go above a certain size we bug up something and the MCU halts. I guess we only have 1023 bytes as I also got STM32CubeProgrammer running so I'll be trying to use that to debug some more. |
|
OK, I think I figured out why I run out of space. It seems the little Blue Pills I got are all 64KB. That sucks. EDIT: That's... not true. Wow. It presents itself as a 64 KB flash sized unit but looking into the flash memory manager I see an index of 0-127 of 1KB pages ranging from 0x08000000 to 0x0801FC00 and I am indeed able to write to the last page. EDIT2: OK. It turns out FLASH_BASE_ADDRESS and the like are not user-overridable despite words to the contrary in the source so no matter what you do, you always write to the last 1 kB page of flash memory. I will have to hack something together that lets you pick which page to write to using the STM32 HAL. There is a lot of info. |
|
Well done getting it to work! 1023 bytes of flash is better than nothing. A recent improvement I've made to the forthcoming release of uLisp is to only save the part of SymbolTable[] that's actually used, which will help. I'd like to be able to update the STM32 version to use the official core, and remove references to Roger Clark's core from the documentation since it's no longer being supported. Do you think that's a good idea? |
|
I think Roger Clark's core is ("unfortunately") still rather popular and has a lot of support for third-party libraries. Maybe people would still want it to run for that reason. Could be worth asking on the forum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started fixing up a patch for #12
I've no real experience working with the emulated eeprom/flash so feel free to rewrite any/all parts.