refactor: make nest-oidc-provider to handle login #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nest oidc provider was used to made login process smooth and easy. Some errors were encountered since sqlite was used. however was corrected
Earlier a user/someone else can login from any password value, however it is changed to -> match the original password value to avoid unauthorized access
Minio requires that the AS supports a policy claim in the id_token, hence it needed to be mapped using the roles available to a user in that tenant, now the user is login based on admin or normal user
Now applications can login without asking for consent from the end user This feature has been warned not to used because 1. asking for user consent is ethical 2. This might be not be bug-free as mentioned below link: https:/panva/node-oidc-provider/blob/v7.x/recipes/skip_consent.md
techsavvyash
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.