Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider doing Guest.details() in more generic way #310

Closed
pvalena opened this issue Jul 20, 2020 · 5 comments
Closed

Consider doing Guest.details() in more generic way #310

pvalena opened this issue Jul 20, 2020 · 5 comments
Labels
good first issue Good for newcomers

Comments

@pvalena
Copy link
Collaborator

pvalena commented Jul 20, 2020

What about /etc/os-release ? I's IMO more generic.

But it's not completely same:

# What you'd probably want
PRETTY_NAME="Fedora 31.20200703.0 (Workstation Edition)"

# Currently is
Fedora release 31 (Thirty One)

Originally posted by @pvalena in #307

@psss psss added the good first issue Good for newcomers label Jul 21, 2020
@pvalena
Copy link
Collaborator Author

pvalena commented Jul 21, 2020

Someone has made a comparison already: https://gist.github.com/natefoo/814c5bf936922dad97ff

@pvalena
Copy link
Collaborator Author

pvalena commented Jul 21, 2020

Note: the rest (not using /etc/os-release like CentOS 6) use /etc/lsb-release.

@psss
Copy link
Collaborator

psss commented Aug 3, 2020

It seems on RHEL6 / CentOS 6 there are only the following release files available:

/etc/centos-release
/etc/redhat-release -> centos-release
/etc/system-release -> centos-release
/etc/system-release-cpe

So we will have to fallback to /etc/redhat-release anyway.

@pvalena
Copy link
Collaborator Author

pvalena commented Aug 5, 2020

@psss are you sure there's no /etc/lsb-release?

Oh right, but there's a system-release. ;)

@psss
Copy link
Collaborator

psss commented Aug 5, 2020

You have to install redhat-lsb-core which is not installed by default. Yes, /etc/system-release can be the last resort.

@psss psss closed this as completed in 95aafee Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants