-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract "package manager" functionality into plugins #2557
Conversation
2a8a800
to
03a0d03
Compare
So, adding a prototype support for
Unfortunately, I can't run tmt's tests because:
|
03a0d03
to
6755d30
Compare
Both beakerlib and tmt should be straightfoward packageable for debian/ubuntu. Are there any contacts that can help with that? This PR would also help with tmt github action |
da15484
to
9e8ef9f
Compare
@happz Shouldn't be the |
I believe it is, see https:/teemtee/tmt/pull/2557/files#diff-f684593942660856c3bdc810b597c3956b4107716a554eece2c2bf08344a9503R635. There's also |
Ouch. I completely missed that I am looking on different file... Thus this PR is usable for my use case ;) |
9e8ef9f
to
4e4993a
Compare
I guess this asks for "I have all bits installed already use case" and/or better check (e.g |
/packit test |
What about making an implementation for homebrew? Packaging there should be relatively fast. |
Could you help with that? Not many macos users in the tmt devel audience. |
Yep, I can help there. Granted I don't have macs anymore, but I still maintain some homebrew packages now and then |
7ac5b7d
to
f24006f
Compare
b3ec95b
to
29f7341
Compare
What a weird failure in the c9s job:
|
I believe we need a newer pip on CentOS. I have a patch ready, I'm just waiting for the remaining jobs to fail, to see whether there's more to fix. |
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Tests are green \o/ Just two comments.
The only failing test is I've run the test manually and it's green, thus ready to merge. |
More and more we see the need for primitives like "install a package". Plugins start to require packages to be present on guests, we already do have
prepare/install
plugin, and the upcoming all mighty install plugin. To support all these functions,tmt.package_managers
would provide necessary primites, allowing implementations to be shipped as plugins.The patch starts building the primitives, converting
tmt.steps.prepare.install
to use them in the process.Pull Request Checklist