Properly detect if test is enabled somewhere #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszachy
requested review from
psss,
happz,
thrix and
janhavlin
as code owners
lukaszachy
added
command | export
happz
approved these changes
Feb 20, 2024
psss
approved these changes
Feb 21, 2024
Had problem to detect 'enabled:false' used in parent node(s) Reported that clone.fmf doesn't set 'enabled' thus default True. But it wasn't the case. ``` == main.fmf == enabled: false test: echo == clone.fmf == ```
psss
force-pushed
the
enabled_somewhere
branch
from
3ab5cb4
to
a8a65b5
Compare
That would be ideal, but no time for that ATM. If PR is accepted as is then I am more than happy |
|
All tests green except for the known issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had problem to detect 'enabled:false' used in parent node(s) Reported that clone.fmf doesn't set 'enabled' thus default True. But it wasn't the case.
Pull Request Checklist