Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disk.driver hw requirement for mrack #2668

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Feb 6, 2024

Pull Request Checklist

  • implement the feature
  • update the specification
  • include a release note

Resolves #2546

tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
@happz happz added step | provision Stuff related to the provision step area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin labels Feb 7, 2024
@happz happz added this to the 1.32 milestone Feb 7, 2024
@happz happz changed the title Have mrack support bootdisk Support disk.driver hw requirement for mrack Mar 5, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this. Just one nitpick. Could you please also update the release note accordingly? The checklist in the pull request description could remind about this ;-) We remove irrelevant items from it and mark as done completed items.

tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
@skycastlelily
Copy link
Collaborator Author

skycastlelily commented Mar 6, 2024 via email

@psss psss added the ci | full test Pull request is ready for the full test execution label Mar 8, 2024
@psss
Copy link
Collaborator

psss commented Mar 8, 2024

/packit test

@psss psss changed the title Support disk.driver hw requirement for mrack Support disk.driver hw requirement for mrack Mar 8, 2024
@psss psss self-assigned this Mar 8, 2024
@psss psss merged commit 4b3da6d into teemtee:main Mar 8, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution plugin | mrack The beaker provision plugin step | provision Stuff related to the provision step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to filter server with boot disk driver
3 participants